Use std::make_{unique,shared} instead of raw new
#3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the first steps to improve
memory management in the Warzone 2100 project.
There are many places which use raw `new/delete`
allocations along with extensive usage of
raw pointers.
This changeset aims to replace raw allocations
with `std::make_unique` and `std::make_shared`
instead of the `std::unique_ptr<...>(new ...)`
and `std::shared_ptr<...>(new ...)` constructs,
respectively.
Since the project-wide C++ standard defaults
to C++14, we should be able to use
`std::make_{unique}` without problem.
Among others, `std::make_{unique,shared}` has
the following advantages over using raw
`new/delete` with `std::{unique,shared}_ptr`
constructors:
* Provides terser syntax without an additional
repetition of the constructed type.
* Provides stronger exception-safety guarantees.
No impact on any of the existing functionality
is expected.
Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
make_shared_unique_instead_of_raw_alloc
branch
from
045ce61 to
9bec7d9
Compare
past-due
reviewed
Nov 27, 2023
`wzmaplib` is used directly by other projects, so we still need to be careful not to upgrade the C++ standard version automatically: this part should be self-contained. Signed-off-by: Pavel Solodovnikov <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ManManson
force-pushed
the
make_shared_unique_instead_of_raw_alloc
branch
from
6d1c739 to
8ae688b
Compare
Signed-off-by: Pavel Solodovnikov <[email protected]>
|
Merged. Thanks @ManManson ! (Btw, if you haven't joined the Discord yet, we have some dev channels & discussions in there as well. Join link is here: https://wz2100.net/webchat/ ) |
|
OK, thanks @past-due ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the first steps to improve memory management in the Warzone 2100 project.
There are many places which use raw
new/deleteallocations along with extensive usage of raw pointers.This changeset aims to replace raw allocations with
std::make_uniqueandstd::make_sharedinstead of thestd::unique_ptr<...>(new ...)andstd::shared_ptr<...>(new ...)constructs, respectively.Since the project-wide C++ standard defaults to C++14, we should be able to use
std::make_{unique,shared}without problem.Among others,
std::make_{unique,shared}has the following advantages over using rawnew/deletewithstd::{unique,shared}_ptrconstructors:No impact on any of the existing functionality is expected.